graphql-inspector icon indicating copy to clipboard operation
graphql-inspector copied to clipboard

Graphql inspector not detecting changes

Open ravar17 opened this issue 1 year ago • 6 comments

Hi,

I would like to use Graphql inspector on Java, Graphql Project. We have installed inspector using GITHUB APP.. below is the screen shot...

Project repo --- Setting ---Github Apps

image

My schema file is at "src\main\resources\schema.graphqls",

I would like to detect the schema changes and send notification to SLACK..

Below are my configurations.

.github\graphql-inspector.yaml


schema: /src/main/resources/schema.graphqls


branch: master

notifications:
  slack: https://hooks.slack.com/services/TMETBJ4/B05GHC6Us/pRBdnzeQoCkffdsfGPxCNbOkq6V

`I also Created package.json file in root.. I don't know if I have to use it or not since we have Java graphql project, not nodejs.

{
    "name": "cssom-purchase-history-backend",
    "graphql-inspector": {
      "diff": true,
      "schema": {
        "ref": "master",
        "path": "src/main/resources/schema.graphqls"
      }
    }
  }

I tried to create PR with some changes in the schema.graphqls, but nothing has happened. Am I missing anything ?

ravar17 avatar Jul 14 '23 14:07 ravar17

Hey @ravar17, Thank you for this issue, i tried to reproduce the flow, and yes, somehow the GitHub Application doesn't work. I try to review the app all over again and release a new version.

TuvalSimha avatar Jul 19 '23 12:07 TuvalSimha

Thanks, @TuvalSimha, is it working now ?

is the below PR for this issue ?

https://github.com/kamilkisiela/graphql-inspector/pull/2591

ravar17 avatar Jul 26 '23 08:07 ravar17

@TuvalSimha just a quick question, how much time I can expect in order to test the GITHUB APPLICATION, if it is working or not. Since PR is still open .. Thanks

ravar17 avatar Jul 26 '23 13:07 ravar17

Hey @ravar17, Thank you again, really appreciate this issue. Not sure how much time, but for this moment you have a workaround, you can use the CLI or the CI - Docs.

TuvalSimha avatar Jul 26 '23 13:07 TuvalSimha

@ravar17 I don't want to bring bad news, but I'm waiting for fix since beginning of 2022 https://github.com/kamilkisiela/graphql-inspector/issues/2062

arxeiss avatar Jul 27 '23 06:07 arxeiss

@TuvalSimha . Thanks for the response, we are working on the Notification part. In order to test the SLACK notification, we should use Inspector GitHub Application. However, I Used GitHub Actions to detect the schema changes and send notification, but here I cant sent schema changes details (such as which fields are getting changes) using Github Action.

ravar17 avatar Jul 27 '23 08:07 ravar17