ci: migrate to pnpm v8

[YassinEldeeb]

[changeset-bot[bot]]

⚠️ No Changeset found

Latest commit: 9a064941d25b0790c627acf692312f030abdf177

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[dotansimha]

@TuvalSimha please review

[YassinEldeeb]

The CI / Test on node 14 / 16 / 18 got pnpm 7.30.0 version

Hey @TuvalSimha, thank you for pointing that out, the ci.yaml was indeed using a very simple setup where the pnpm version was specified in the workflow, I've modified it similarly to read it from the package.json packageManager field.

should we push also the update pnpm-lock.yml file?

It's usually advisable to do a pnpm update whenever pnpm version change at a major version, bc the lock tend to be structured a bit differently, and packages usually push versions to support pnpm new major releases.

[YassinEldeeb]

Tests are failing on Node 14 bc pnpm v8 can only run on v16.14 and above

[TuvalSimha]

@YassinEldeeb I guess i can close this one because we already updated to pnpm 9. Thanks!