graphql-inspector icon indicating copy to clipboard operation
graphql-inspector copied to clipboard

feat: check deprecated directive added or removed from input field and field argument

Open ZejunNinaWang opened this issue 2 years ago • 0 comments

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Description

The GraphQL Spec recently allowed the deprecated directive to be added on input field and field argument (pr link). However, the diff API in latest graphql-inspector does not detect the deprecated directive added on input field and field argument. This pull request adds checking for deprecated status on input field and field argument.

Fixes #2199

Type of change

Please delete options that are not relevant.

  • [ ] New feature (non-breaking change which adds functionality)

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  1. Switch to this branch
  2. Run npm test -f 'packages/core/__tests__/diff/input.ts' -t 'deprecation added / removed' AND then run npm test -f 'packages/core/__tests__/diff/argument.ts' -t 'deprecation added / removed'. You should see the newly added tests passed

Checklist:

  • [x] I have followed the CONTRIBUTING doc and the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

ZejunNinaWang avatar Nov 01 '22 20:11 ZejunNinaWang