graphql-inspector icon indicating copy to clipboard operation
graphql-inspector copied to clipboard

Allow for data key in Introspection diff

Open tvvignesh opened this issue 3 years ago • 2 comments

Description

Addressing feedback from @AllexVeldman here: https://github.com/kamilkisiela/graphql-inspector/pull/2054#discussion_r774396413 with respect to allowing optional data key during introspection.

Fixes https://github.com/kamilkisiela/graphql-inspector/pull/2054#discussion_r774396413

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

Checklist:

  • [x] I have followed the CONTRIBUTING doc and the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

tvvignesh avatar Jan 02 '22 10:01 tvvignesh

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/theguild/graphql-inspector/6opKAXa2TjnKX46ffHnfqMc9vQLD
✅ Preview: https://graphql-inspector-git-fork-tvvignesh-introspect-8ab149-theguild.vercel.app

vercel[bot] avatar Jan 02 '22 10:01 vercel[bot]

@kamilkisiela Is there anything we need to do to advance this PR?

AllexVeldman avatar May 05 '22 13:05 AllexVeldman