graphql-hive icon indicating copy to clipboard operation
graphql-hive copied to clipboard

Fix router docker file

Open rcrowe opened this issue 3 years ago • 3 comments
trafficstars

Seems when I raised the PR with a Dockerfile I had only checked the binary ran; since then I've tried to call our graph & uncovered the following issues fixed by this PR:

  • [x] Fix entrypoint was wrapped in shell, so args are not passed direct
  • [x] CA bundle wasn't available so TLS requests failed
  • [x] Drop RUST_BACKTRACE

rcrowe avatar Sep 01 '22 10:09 rcrowe

⚠️ No Changeset found

Latest commit: deb61c6c216b768a101e631ce815bd36fb6cf461

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Sep 01 '22 10:09 changeset-bot[bot]

@kamilkisiela @n1ru4l Any chance you could take a look at this PR? 🙏🏻 Currently, the container is unusable.

Thank you in advance 🙇🏻

rcrowe avatar Sep 06 '22 13:09 rcrowe

Any chance this could be looked at? @kamilkisiela @n1ru4l

We've built this image to our own registry for now, but would be good to use an official one.

RMHonor avatar Oct 20 '22 09:10 RMHonor

Thanks @rcrowe Sorry for the delay on this one, we'll try to review and get this in soon :)

dotansimha avatar Dec 27 '22 13:12 dotansimha

@kamilkisiela I think we can close this one, since it was already fixed?

dotansimha avatar Jan 18 '23 08:01 dotansimha

https://github.com/kamilkisiela/graphql-hive/pull/972 not merged yet

kamilkisiela avatar Jan 18 '23 08:01 kamilkisiela

Hi @rcrowe Thank you for this PR, there was some more fixes needed to get this fully working, so @kamilkisiela created this PR: https://github.com/kamilkisiela/graphql-hive/pull/972 We are looking for feedback if you are interested in giving it a try. we plan to get this merged by next week.

dotansimha avatar Jan 18 '23 08:01 dotansimha