apollo-angular icon indicating copy to clipboard operation
apollo-angular copied to clipboard

[Docs] Document Apollo.subscribe()

Open kamilkisiela opened this issue 7 years ago • 10 comments

kamilkisiela avatar Oct 26 '18 12:10 kamilkisiela

would love to work on this as my first issue here, @kamilkisiela please give me the go ahead for this

theNaut1lus avatar May 04 '19 17:05 theNaut1lus

@co16353sidak 🆗 👍 let me know if you need anything and feel free to contact me :)

kamilkisiela avatar May 06 '19 12:05 kamilkisiela

@kamilkisiela Is it open to work on?

divyanshu-rawat avatar Nov 04 '19 15:11 divyanshu-rawat

@divyanshu-rawat yes :) It's there but it's not in the docs

kamilkisiela avatar Nov 04 '19 15:11 kamilkisiela

So, @kamilkisiela can I work on this issue ?

divyanshu-rawat avatar Nov 04 '19 15:11 divyanshu-rawat

of course! Let me know if you need anything from me

kamilkisiela avatar Nov 04 '19 15:11 kamilkisiela

@kamilkisiela , cool then can you assign me this issue :)

divyanshu-rawat avatar Nov 04 '19 15:11 divyanshu-rawat

I assigned you, put proper labels and created a milestone :))

kamilkisiela avatar Nov 04 '19 15:11 kamilkisiela

@kamilkisiela do I have to document Apollo.subscribe() here?

https://www.apollographql.com/docs/ios/api/Apollo/extensions/ApolloClient/#methods

By adding this description I guess.

Subscribe to a subscription
Parameters:

subscription: The subscription to subscribe to.
fetchHTTPMethod: The HTTP Method to be used.
queue: A dispatch queue on which the result handler will be called. Defaults to the main queue.
resultHandler: An optional closure that is called when mutation results are available or when an error occurs.
Returns: An object that can be used to cancel an in progress subscription.

divyanshu-rawat avatar Nov 12 '19 14:11 divyanshu-rawat

@kamilkisiela could you please give any insights on above comment?

divyanshu-rawat avatar Nov 24 '19 14:11 divyanshu-rawat