apollo-angular icon indicating copy to clipboard operation
apollo-angular copied to clipboard

Published 20 hours ago • verified publisher icon kamilkisiela

feat: adds `watchFragment` support

Open alessbell opened this issue 1 year ago • 1 comments

Adds support for a new method available on an ApolloClient in 3.10, watchFragment (docs).

To do

  • [ ] docs
  • [ ] update the Apollo Client version once 3.10 is released

alessbell avatar Apr 04 '24 21:04 alessbell

🦋 Changeset detected

Latest commit: 4f986b2c69fc33b0bb8903b688ce8fc5a91e7b5a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
apollo-angular Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Apr 04 '24 21:04 changeset-bot[bot]

Looking forward to use watchFragment 🙂

Is help needed to land this PR?

(apollo-client 3.10 has been released)

chimurai avatar Jul 06 '24 12:07 chimurai

Hi @chimurai 👋 Glad to know you're excited for this feature :) I'll get the PR updated and ready for final review.

alessbell avatar Jul 09 '24 17:07 alessbell

This is ready for a final pass @PowerKiKi - thanks for the reviews!

Regarding docs: would you be ok with a fast follow PR? I was thinking of updates to the Using Fragments page but I don't have much bandwidth in the next few weeks. Happy for any suggestions here.

alessbell avatar Jul 17 '24 11:07 alessbell

Not sure why that one test timed out - @PowerKiKi any ideas there?

alessbell avatar Jul 22 '24 14:07 alessbell

It looks like these tests are failing on main - anything I can do to help unblock this PR, @PowerKiKi?

alessbell avatar Jul 30 '24 19:07 alessbell

It's fine if the docs comes in the next PR.

I fixed the CI that broke because of Renovate in the unrelated #2267.

Before merging this, I'd like to understand the story around the newly introduced class Fragment. I think it only makes sense if it is used by code generations tools. What's your opinion ? Will @graphql-codegen/cli be adapted accordingly ? or should we drop the class ? or is it useful for something else ?

PowerKiKi avatar Aug 06 '24 11:08 PowerKiKi

Thanks @PowerKiKi - I'll descope codegen for now and have gone ahead and removed the Fragment class from the PR. Let me know if there's anything else, appreciate the reviews!

alessbell avatar Aug 13 '24 18:08 alessbell

Squashed and needed to merge master one last time - lmk if that's an issue. Thanks again @PowerKiKi.

alessbell avatar Aug 13 '24 19:08 alessbell

Thanks for your work. It's been released as 7.1.1 (7.1.0 release process crashed)

PowerKiKi avatar Aug 14 '24 21:08 PowerKiKi