apollo-angular icon indicating copy to clipboard operation
apollo-angular copied to clipboard

Upgrade to Angular 14

Open dlq84 opened this issue 3 years ago • 5 comments

This PR upgrades to Angular 14. It does pass yarn test and yarn build locally.

It also includes this PR #1781, closed that one because this replaces it.

dlq84 avatar Jul 15 '22 09:07 dlq84

Ok, It did build correctly, but the "testapp" fails on Angular 14 because it expects the --graphql flag to be a string. But I'm not too familiar with github CI to know if my fix works. Let me know if it works and if it doesn't, suggestions on how to fix it.

dlq84 avatar Jul 15 '22 09:07 dlq84

So looks like if you compile with Angular 14 you can't use it in previous versions: https://github.com/angular/angular/issues/46748#issuecomment-1178817658

Should we just restrict this to Angular 14 or do you want to keep compiling with Angular 13?

dlq84 avatar Jul 17 '22 18:07 dlq84

@cypress/[email protected] changed map/file structures, this is now handled.

dlq84 avatar Jul 21 '22 09:07 dlq84

@de-dan Is there anything I need to do to get rid of Angular 12 and 13 tests? Except those and gh-release it looks like it's ready now.

dlq84 avatar Jul 27 '22 10:07 dlq84

I don't know unfortunately. I've seen your changes in .github/workflows/main.yml - that should be it. @kamilkisiela could you have a look?

de-dan avatar Jul 27 '22 11:07 de-dan

Thank you

kamilkisiela avatar Aug 15 '22 07:08 kamilkisiela

4.0.0

kamilkisiela avatar Aug 15 '22 07:08 kamilkisiela

/theguild newsletter

charlypoly avatar Sep 26 '22 16:09 charlypoly