client icon indicating copy to clipboard operation
client copied to clipboard

Legacy Offhandgap

Open 5HT2 opened this issue 3 years ago • 19 comments

Suggested by <@!322183265463304192>.

Option so that your totem is always out but when holding right click with a sword, a gapple will go to your offhand and be eaten. This worked in a previous version (v1.1.6 release) but currently does not. Video showing how it worked in that version https://youtu.be/iZvNnxmPVyA

5HT2 avatar Dec 12 '20 22:12 5HT2

AutoOffhand is designed to be only switching items or switching to totem when needed to have ability of manually overriding item in offhand. Check weapon under gapple should does the similar thing already.

Luna5ama avatar Dec 12 '20 22:12 Luna5ama

I only left the description of the original suggestion as a courtesy, I've seen multiple people want the old behavior of right click to gap for whatever reason.

5HT2 avatar Dec 12 '20 22:12 5HT2

I only left the description of the original suggestion as a courtesy, I've seen multiple people want the old behavior of right click to gap for whatever reason.

🗿 It is just gonna break compatibility and anticheat doesn't like switching items fast as well

Luna5ama avatar Dec 12 '20 22:12 Luna5ama

Plugins are able to annotate if they're incompatible with a module and then not allow being enabled at the same time.

5HT2 avatar Dec 12 '20 22:12 5HT2

If it is incompatible with AutoOffhand then there is no point of having it because AutoOffhand is an essential module for pvp

Luna5ama avatar Dec 12 '20 22:12 Luna5ama

@l1ving I never explicitly said that to be the case. Plugins will have to handle that themselves. I implore you to stop thinking of plugins as wrappers for single modules.

BitBuf avatar Dec 12 '20 22:12 BitBuf

I clearly meant modules

5HT2 avatar Dec 12 '20 22:12 5HT2

Ah fair, but to be quite honest it was not clear. Don't try and tell me I'm the cheeser in English when you're interpreting "said context" as literally "this person has previously said the word context".

BitBuf avatar Dec 12 '20 22:12 BitBuf

The reason of having totem always out is just preventing death. AutoOffhand already does it by checking the health and potential damage from enemy. Having OffhandGapple and CheckWeapon on will put a gapple in your hand when you holding a sword. And switching back to totem when you are in risk of death.

Luna5ama avatar Dec 12 '20 22:12 Luna5ama

Some people still prefer manually controlling it. I'm not here to explain it, it's a suggestion for a plugin and it doesn't hurt anybody to add it as a plugin.

5HT2 avatar Dec 12 '20 23:12 5HT2

Me and @l1ving did agree on this. The issue will remain open.

BitBuf avatar Dec 12 '20 23:12 BitBuf

Some people still prefer manually controlling it. I'm not here to explain it, it's a suggestion for a plugin and it doesn't hurt anybody to add it as a plugin.

Again, I already said the plugin is going to be incompatible with AutoOffhand which will cause more random complaints and troubles

Luna5ama avatar Dec 12 '20 23:12 Luna5ama

They will never be enabled at the same time.

BitBuf avatar Dec 12 '20 23:12 BitBuf

Plugin modules are able to annotate if they're incompatible with a module and then not allow being enabled at the same time.

5HT2 avatar Dec 12 '20 23:12 5HT2

They will never be enabled at the same time.

:wonk: which will cause more random complaints and troubles

Luna5ama avatar Dec 12 '20 23:12 Luna5ama

If users can't read a popup that says "X is not compatible with Y" then that's their fault

5HT2 avatar Dec 12 '20 23:12 5HT2

If users can't read a popup that says "X is not compatible with Y" then that's their fault

No, they will just ask you why is it incompatible and ask you to make them compatible instead

Luna5ama avatar Dec 12 '20 23:12 Luna5ama

:woeis:

5HT2 avatar Dec 12 '20 23:12 5HT2

It is just gonna break compatibility and anticheat doesn't like switching items fast as well

ik its an old thread but this works on most servers ive used it on including 5b, cpvp.cc among others. a max switch thing (similar to gamesense) where you can only switch offhand item a few times until it wont switch it anymore (would ignore totems so you dont die easily) works well.

Doogie13 avatar Apr 11 '21 13:04 Doogie13