Peter Ludemann
Peter Ludemann
With the latest commit (b2311c0c93cf4fc50906153433978032adfc3d35), I still see a few errors (I don't have time right now to look into these. The "archive" error might be an artifact of some...
Jan reminded me that there are still some ASAN problems with libarchive: https://github.com/SWI-Prolog/packages-archive/issues/16
I ran the tests with ASAN for the current image (dd7f4bdcaeec01f3c555d30a160de16195af190c) ... there seem to be some new ASAN errors that I hadn't seen before (including one in protobufs(!)). My...
Confirmed on my system (gcc-12) that those are the only two errors.
Here is one example of a potential bug that is fixed by using `std::string`: https://github.com/rdfhdt/hdt-cpp/pull/283/commits/e77521a985cf21081e5142ee8af77f499a9158ff
Another potential bug that should have been fixed with `std::vector`: https://github.com/rdfhdt/hdt-cpp/pull/283/commits/ba7742af2ebb504165af9d5f9ae045a5bc9cba59 (this was discovered by a compiler warning). In general, most raw pointers in the code should be replaced by...
Does this PR incorporate the bugs I fixed in PR https://github.com/rdfhdt/hdt-cpp/pull/283 ? (see also Issue https://github.com/rdfhdt/hdt-cpp/issues/284 and Issue https://github.com/rdfhdt/hdt-cpp/issues/274) (hdt-cpp appears to be unsupported ... it's been over a year...
The changes I made were due to compiler errors and warnings. I don't know which flags caused the warnings because the problems were reported from a number of different platforms...
Commit https://github.com/rdfhdt/hdt-cpp/pull/283/commits/ba7742af2ebb504165af9d5f9ae045a5bc9cba59 is a minimal change to get rid of a compiler warning; it could instead have been `freq(null-ptr)` -- as far as I can tell, that should work also....
Documenting it seems a reasonable solution; but your answer also tells me that I don't understand how `-goal` and the arguments to `PlEngine(` work. I'll add this to my "documentation...