Timur Kamaev

Hide first/last axis values

1

Hi! Is there any good way to not to draw first and last axis values (at least for yaxis)? I tried to use `return ""` hack in custom ValueFormatter but...

[ telegram sender ] bad redis key naming / key storing

3

- connector.RemoveUser is never being used (except for tests) - non-unique chat titles are not allowed: https://github.com/moira-alert/moira/blob/1084b514bb3fe7b73b7a69adb305eb04590a62aa/senders/telegram/handle_message.go#L37

[ trigger metrics ] Show "Delete" button only when it's necessary

4


[ plotting ] Empty plots are possible

8

Moira renders metric plots with every notification (if delivery channel supports this). However, from time to time we see empty images in notifications. Empty images can be caused by bugs...

https://github.com/moira-alert/moira/blob/6a740094d6dcc91673d6e2263e54371017e60daa/api/controller/trigger_metrics.go#L68 ``` GET http:// moira_api/api/trigger/4da2e01c-3e01-469c-a247-ad5da36bbbb3/metrics HTTP/1.0\ from by kamaev - 500 67B in 2.958639ms - Panic: runtime error: integer divide by zero /usr/local/go/src/runtime/debug/stack.go:24 +0xa7 /go/src/github.com/moira-alert/moira/api/middleware/logger.go:46 +0x185 runtime/debug.Stack(0xbf1f00e8673d977d, 0xe35b18d07b1, 0x187c2e0) github.com/moira-alert/moira/api/middleware.RequestLogger.func1.1.1(0x10717a0,...

- Get rid of map[string]string for senderSettings, use strongly typed parsing instead - Make api web config part of main api config as both of them consist of related fields...

https://github.com/moira-alert/moira/blob/4c03982d9e87e38354a5b648971cda6f580811f3/checker/check.go#L184 Currently used conditions leads to transitions into EXCEPTION state when: `timeSinceLastSuccessfulCheck >= triggerChecker.ttl` only because of timeSinceLastSuccessfulCheck = checkData.Timestamp - 0 and it's very unexpected to receive messages like...

[hidden pages: /notifications ] Remove unnecessary notifications from queue using trigger.ID instead of contact.Value

1

Хочется научиться удалять нотификации, сгруппированные по triggerID и удалять тоже сразу все нотификации.