Asap2 icon indicating copy to clipboard operation
Asap2 copied to clipboard

Changed build target to .NET Standard 2.0 🚀

Open sven-n opened this issue 3 years ago • 5 comments

Currently, this project targets the .NET Framework. However, we want to migrate to .NET 5 and beyond.

I analyzed the code and found no issues when it targets .NET Standard 2.0, which is compatible to both .NET Framework and newer .NET versions.

If you have access to the published nuget package (#10, @bhattvishal ?), it would be great to get an updated package as well.

Thank you 😀

sven-n avatar Sep 14 '22 08:09 sven-n

The automatic build system did not like the commit. Can you please check the error?

For the nuget package it is an unofficial upload, that I did not do. I will try again to get the rights to replace that version,

kallemooo avatar Sep 14 '22 21:09 kallemooo

The target name of the pre-build had to be changed. It should work now.

sven-n avatar Sep 15 '22 07:09 sven-n

Hi, any news? You can re-run the build check, btw ;-)

sven-n avatar Nov 17 '22 14:11 sven-n

Hi, any news? You can re-run the build check, btw ;-)

The change causes the build to fail. Please check this.

Did you build using the command line tools on your computer as the CI build does?

I cannot check this as I do not have windows installed any longer.

kallemooo avatar Nov 20 '22 21:11 kallemooo

Oh, didn't expect it still fails :-( I built it on my machine using vs 2019. I'll check it with the command line when I'm back at the office.

sven-n avatar Nov 20 '22 21:11 sven-n