mini-media-player icon indicating copy to clipboard operation
mini-media-player copied to clipboard

"dynamic" STOP button

Open koying opened this issue 5 years ago • 3 comments

I tried to convince the lovelace team to have a STOP button if the backend integration supports it, but have not been successful (https://github.com/home-assistant/home-assistant-polymer/pull/4892), so I implemented it in mini-media-player, instead.

As apparently having play/pause + stop buttons (if applicable) is not as desirable as I thought it would, just checking if you're interested in a PR.

koying avatar Feb 20 '20 19:02 koying

Hello, PRs are always welcome, I wouldn't want to make this the default layout though, so would have to be as an optional option.

kalkih avatar Feb 24 '20 20:02 kalkih

Thanks for your answer. Would it be ok with a logic like this:

if play_stop is visible and play_pause is visible
  if stop is supported
    show stop button
  else
    // avoid having 2 play button side-by-side
    hide button
  endif
endif

koying avatar Feb 25 '20 11:02 koying

@koying I came across this when searching old HA pull requests and issues for the media player not having a stop button. I realize this issue is .. 2 years old now but I had to note this down somewhere :). For Kodi, stop has a distinct difference from pause in that it determines the resume-from timestamp. If you simply pause or turn off, there may be no accurate resume-from timesetamp. If you decide to pick the idea up again with HA this is a pretty compelling reason to include it.

apaperclip avatar Feb 10 '23 02:02 apaperclip