mini-graph-card icon indicating copy to clipboard operation
mini-graph-card copied to clipboard

implement more group_by options

Open blind-coder opened this issue 2 years ago • 13 comments

Implement group_by options week, month and year

blind-coder avatar Sep 05 '22 13:09 blind-coder

Does this work now? I was just looking for this and now sure how to use it.

minermartijn avatar Sep 14 '22 07:09 minermartijn

Does this work now? I was just looking for this and now sure how to use it.

It needs to merged, but I use it on my instance already. The grouping isn't perfect for month and year, but works solidly for week.

blind-coder avatar Sep 14 '22 07:09 blind-coder

When is this expected to be released? This is just the thing I've been waiting for! 👍

acmaarts avatar Sep 22 '22 12:09 acmaarts

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 22 '22 13:10 stale[bot]

Hi, There are a couple changes needed before we can integrate them though, as mentioned above. Please also rebase your changes onto the dev branch and target it instead.

Thanks a lot for your contribution! And my apologies for the slow review

jlsjonas avatar Oct 24 '22 22:10 jlsjonas

Hello,

I have made the changes, thanks for the input. I'm not familiar with rebase and pushing afterwards, I hope I did it correctly. If not, let me know and I'll file a new PR with properly forked branches from dev.

blind-coder avatar Oct 25 '22 05:10 blind-coder

@blind-coder thanks for the changes! It looks like a few commits from master sneaked in though :) Could you interactively rebase your branch, removing the 3 readme-related commits & force push one more time? Thanks!

jlsjonas avatar Oct 30 '22 09:10 jlsjonas

Hi Jonas,

I'm on a business trip this week and next. I'll chek it out afterwards.

Kind regards, Benjamin

blind-coder avatar Nov 03 '22 08:11 blind-coder

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 03 '22 09:12 stale[bot]

Still an active issue, got it! Removing stale label.

stale[bot] avatar Dec 06 '22 22:12 stale[bot]

Still an active issue, got it! Removing stale label.

stale[bot] avatar Dec 06 '22 22:12 stale[bot]

Still an active issue, got it! Removing stale label.

stale[bot] avatar Dec 06 '22 22:12 stale[bot]

Still an active issue, got it! Removing stale label.

stale[bot] avatar Dec 06 '22 22:12 stale[bot]