herald icon indicating copy to clipboard operation
herald copied to clipboard

Cap all computations based on untrusted data

Open GallagherCommaJack opened this issue 5 years ago • 2 comments

for example:

  • limit number of kdf iterations for out of order message delivery
  • limit max message size
  • patch serde_cbor to limit maximum memory allocation

I'm not sure how best to pick these limits, so for now I'm going to leave TODO's in the code that reference this issue.

(probably partial) list of places in the code where this needs to be fixed:

  • [ ] read_cbor
  • [ ] send_cbor
  • [ ] serde_cbor internals?
  • [ ] unsent message storage
  • [ ] registration loop
  • [ ] login loop

GallagherCommaJack avatar Sep 09 '19 23:09 GallagherCommaJack