kotlin-multiplatform-oidc icon indicating copy to clipboard operation
kotlin-multiplatform-oidc copied to clipboard

Published 20 hours ago • verified publisher icon kalinjul

Add wasm target

Open SuperCaliMan opened this issue 1 year ago • 9 comments

Hi, thanks for getting into this project!

Checklist for your PR:

  • [X] Check if there's any open issue
  • [X] Please file your request against the develop branch

Description of your changes

Hi i implemented wasm target, to import and use this library in a wasm application.

How has this been tested?

I test it with OpenID link

Is this a (API-) breaking change?

No

SuperCaliMan avatar Jun 20 '24 07:06 SuperCaliMan

Hi, this only adds wasm target without providing implementation, right? Why does this need ktor eap?

kalinjul avatar Jun 20 '24 15:06 kalinjul

Hi, this only adds wasm target without providing implementation, right? Why does this need ktor eap?

Ktor support wasm target only in eap

SuperCaliMan avatar Jun 21 '24 08:06 SuperCaliMan

Any news on this PR? This feature would be a great benefit

ralfstuckert avatar Aug 27 '24 05:08 ralfstuckert

Ok so there are some things in this PR I'd like to discuss, i'll put my questions in a review. But also I'd like to wait for a stable ktor release supporting wasm before requiring a beta or EAP in this library.

kalinjul avatar Aug 27 '24 13:08 kalinjul

Hi, any news on this? Ktor 3 is now in RC and it will soon be stable

maicol07 avatar Sep 12 '24 10:09 maicol07

Hi, any news on this? Ktor 3 is now in RC and it will soon be stable

Hi, I will update this PR when Ktor 3 is released in the stable channel.

SuperCaliMan avatar Sep 12 '24 12:09 SuperCaliMan

please uodate ktor version 3 in rc version becouse it is make issue with another packages in compose multiplatform

the-best-is-best avatar Sep 15 '24 07:09 the-best-is-best

please uodate ktor version 3 in rc version becouse it is make issue with another packages in compose multiplatform

Ktor 3.0.0-rc-1 require to update compose version

SuperCaliMan avatar Sep 17 '24 07:09 SuperCaliMan

Ktor 3.0.0 https://github.com/ktorio/ktor/releases/tag/3.0.0 is stable now

DatL4g avatar Oct 10 '24 10:10 DatL4g

Hi, I have just upgraded ktor to stable version 3.0.1.

SuperCaliMan avatar Nov 07 '24 11:11 SuperCaliMan

since the required ktor 3 is stable by now: any news on this PR?

ralfstuckert avatar Nov 27 '24 06:11 ralfstuckert

Hi, i'm still waiting @kalinjul review

SuperCaliMan avatar Dec 05 '24 12:12 SuperCaliMan

This was closed automatically because i deleted the develop branch, could you change to the main branch?

We'll need this rebased, as main has been updated to ktor 3 as well. Also, there are still TODOs in the code, so i guess it's not ready yet.

kalinjul avatar Dec 05 '24 19:12 kalinjul

@SuperCaliMan can you reopen this or make a new pr to main branch?

kalinjul avatar Dec 10 '24 19:12 kalinjul