phpinspectionsea
phpinspectionsea copied to clipboard
kalessil
PHP named attributes are not taken into account
| Subject | Details |
|---|---|
| Plugin | Php Inspections (EA Ultimate), |
| Language level | PHP 8.2 |
Current behaviour
If I use a named attributes for a function it's not understood.
If I write :
$token = uniqid(more_entropy: true)
EA raise the error : Please provide 'more_entropy' parameter in order to increase likelihood of uniqueness.
It would be nice, il named attributes are understood by EA because this feature helps a lot when you have a lots of optional parameter to a function.
Other methods have the same issues e.g. json_decode
And it seems to be a duplicate of:
- https://github.com/kalessil/phpinspectionsea/issues/1639
- https://github.com/kalessil/phpinspectionsea/issues/1725
- https://github.com/kalessil/phpinspectionsea/issues/1807
- https://github.com/kalessil/phpinspectionsea/issues/1845
The cause seems to be in this line of code where the arguments length is being checked as greater or equal to 4
I guess if possible the arguments should be checked for the index flags and take that argument
@ea-inspections-team: +1 request to address this at least in the mentioned inspections.
Thank you for reporting @guerinetn.
Question for everyone: are uniqid and json_decode are the only functions which we need to consider for hot-fix release?
Hello @ea-inspections-team at the moment it's the only method with this issues. Thanks for your reply
@ea-inspections-team Is there a reason this open PR https://github.com/kalessil/phpinspectionsea/pull/1815 has not been picked up yet to resolve this issue?
@ea-inspections-team: +1 request to address this at least in the mentioned inspections.
+1
@kalessil I wanted to kindly check with you if this is something @ea-inspections-team is working on?
Perhaps some pointers could be given in order help me (or other people watching this issue) out in trying to create a PR addressing this issue?