magehero Replace JSON editor with actual web form

Replace JSON editor with actual web form

Open kalenjordan opened this issue 10 years ago • 7 comments

I think it's about time :)

Oct 30 '14 13:10 kalenjordan

Implement it via TWIG or AngularJS?

Nov 06 '14 02:11 SchumacherFM

Angular sounds interesting. Would be fun to learn. Might add a little overhead with learning curve for me. You know how I like to review PRs :)

Another reason I wanted to wait for this was to wait until the design is complete.

Nov 06 '14 02:11 kalenjordan

Angular means also dumping jQuery and its tools ... that would end up in a big refactoring of the JS ...

Nov 06 '14 03:11 SchumacherFM

Ya that does sound interesting and I'd love to learn it. But I'm pretty sure it would make my (already slow) responses on PRs even slower :(

Nov 06 '14 03:11 kalenjordan

How can I convert your answer to type boolean?

Nov 07 '14 02:11 SchumacherFM

I'll make your life easy.

(boolean)$kalensAnswer = false

Nov 07 '14 02:11 kalenjordan

Yeah, Angular just probably isn't the right technology to use here... just add a controller and make a normal webform.

Feb 12 '15 20:02 navarr