Konstantin Alekseev

Results 32 comments of Konstantin Alekseev

@bblommers thanks for info, would be good to have that mentioned in the readme.

it seems that develop branch doesn't contain all the master commits so pr includes a couple of comments from master

@alex-yobota sorry but my original plan is different from what maintainers want: > Yes sure but still I was challenging the fact that we could make this even more flexible...

@gvizquel Hi, you can disable HistoricalRecords field check with skipif, see example `skipif_streamfield` https://github.com/kalekseev/django-extra-checks#ignoring-check-problems If you have time to debug please provide information what you have in `self._obj` here: ```...

@gvizquel thank you for the source code, I was able to reproduce the error with simple history field. The root cause of the error is that simple history generate a...

I think it possible to implement only using plugin code, you type your request explicitly with `request: Request` in arguments, so there is no way for mypy to understand that...

This was changed in the https://github.com/typeddjango/djangorestframework-stubs/commit/cf9d492ec01f99e9a3fa89558aa1fbf1a749bc22#diff-19f9224eec09114fbeb9cb2aa07f53c2f1efb422a42812ec6a9bebe74e8993caL10, there are many things that changed in this pr to use more specific types, I've created https://github.com/typeddjango/djangorestframework-stubs/pull/101 where I rollback some of that changes,...

Oh, I misunderstood your problem on first read, just annotate it as APIView and use `if isinstance(view, ViewSet)` then you will be able to access `view.action`

> @kalekseev because you did good work with last PR please find time to fix this issue. I'm willing to help, because I think your first comment here is valid....