Kai Krakow

Results 1209 comments of Kai Krakow

That was my first thought... But I'm still somewhat uncomfortable with that idea... But I can prepare a PR for that, I already have the idea on mind. In the...

Maybe you should setup a CI test in this project, run that with `-Werror` and remove `-Werror` from the default git checkout? E.g., Gentoo QA is complaining about `-Werror` and...

Yeah, Github Actions was what I was thinking about. It would allow contributors to get direct feedback on pull requests.

Without having that tested, couldn't we just do: ``` diff --git a/src/bees-hash.cc b/src/bees-hash.cc index 7ba562f..117452d 100644 --- a/src/bees-hash.cc +++ b/src/bees-hash.cc @@ -617,6 +617,7 @@ BeesHashTable::open_file() Stat st(new_fd); off_t new_size =...

I'd go for round down... Because hash table sizes below 16 or 32 MB probably make no sense anyway. And then just ignore the few extra data, a slack size...

BTW: I volunteer to add the size configuration option if you don't mind. I could need one or another advice, and we should settle on an expected behavior first.

When the crawler reaches the maximum transaction id and idles waiting for new transactions, it completely processed the filesystem. But this is a bit difficult because bees itself modifies the...

Maybe it's easier to just add an option `--exit-after=4h` or something like that - whatever that means for passes and transids. It's a best-effort strategy for those who want to...

No, it's an existing file system with existing hash table. Bees has already been running on it for months.

I didn't have time/resources yet to check again with that version.