hugo-tranquilpeak-theme icon indicating copy to clipboard operation
hugo-tranquilpeak-theme copied to clipboard

Remove develop branch

Open kakawait opened this issue 2 years ago • 7 comments

Lot of work mess for nothing

  • [ ] #481
  • [ ] Delete fixed on develop tag
  • [ ] Update .github/CONTRIBUTION.md

kakawait avatar Aug 15 '21 06:08 kakawait

hi, @kakawait have you consider using GitHub actions to make life easier ???

stiliajohny avatar Sep 07 '21 20:09 stiliajohny

Yes but to be honest lake of time to invest for the moment. I'd like to concentrate on things that I've logged since few years.

Maybe take more time on tools and processes after 0.6.0

kakawait avatar Sep 07 '21 21:09 kakawait

I would be happy to put something together on Github Actions ;)

stiliajohny avatar Sep 10 '21 09:09 stiliajohny

I would be happy to put something together on Github Actions ;)

My dream will be per PR as something to run hugo (at least to check basic errors), eslint and then deploy the result somewhere (maybe netlify, see #488) as Preview app to get a visual render before merging to master.

But before that I'd like to improve dev/tooling to avoid npm/grunt and switch to Hugo pipe, see #481

PS: I see other Hugo theme succeed my dream so I think is not so impossible haha. But I don't know about the cost (if there are) for netlify

kakawait avatar Sep 10 '21 10:09 kakawait

But currently the main problem of develop branch is time between feature/PR is merged and get "publicly" accessible. I don't think is worth keeping/buffering everything in develop branch.

Most people except that after proposing PR (and accepted/merged) to get result asap and not wait for the maintainer (me) to release the new version

kakawait avatar Sep 10 '21 11:09 kakawait

agree,

I am truly an advocate of google's approach of emerging in master if works and if broke fix forwards.

stiliajohny avatar Sep 12 '21 20:09 stiliajohny

I am gonna fork and get some GitHub actions that do the tests... very theoretically,

I would have got the following checks.

Markdown Link checker ( for validation the URL is valid ) ESlint Hugo check Update PR with a bot comment

this kind of thing

stiliajohny avatar Sep 12 '21 21:09 stiliajohny