added a flag to use v2 detection; works better on my mac; need more testing

[ghost]

added ability to pass --ipdetect2 to use the new ip detection method, still a WIP, we need to test on more architectures

[fperegrinvs]

I'm not comfortable about having multiple implementations of the same feature., and extra switch would be my last resort. I would rather test if this algo could replace the current one.

[ghost]

the intention is you can use the flag for testing (without breaking backwards compatibility); and if its proven to work we can replace the main method

[fperegrinvs]

Humm, I agree. Maybe we can create an alt build and offer to some mac users who are unable to use sw proxy now.

[ghost]

@kakaroto @lstern so I've been testing with this algorithmn as much as I can.

From what I can tell, it will ALWAYS include the proper IP address in the list of IP address returned, BUT it isn't always the first one. I think a dropdown in the GUI or a simple prompt headless would solve this? What do you guys think

[fperegrinvs]

So we now have 3 pull requests trying to solve the same problem.

• We should support users with multiple ips anyway. Only @skroll request handles that.
• We should fix the ip detection code. Using a package sounds like the safest option but I still don't know in which scenarios the old code was broken.
• Although I feel that a packaged option is better, breaking ip detection again would be disastrous so we should move very carefully with this. Adding the v2 option and reverting the ip code seems like the safest move,

[kakaroto]

The old code was only broken in @azrethos 's case where he has two valid external IP addresses but wants to use the non-default one. As he just commented, even with netifaces, his IP is in the list but it may not be the first one in the list, so it doesn't solve his problem. In that very specific use case, setting it manually through GUI or command line option is the only solution. Don't add the v2 option, but just add the v2 code into the GUI and make the IP entry into a combobox.

[kaitoarief]

as @kakaroto said, i also have this problem. i want to use the non-default ip for some reason. if only you can make user to input manual the ip address, it would be the best. if only i know some python code and how to compile, i can change it manual.