Beyond20
Beyond20 copied to clipboard
kakaroto
Option "The Hexblade: Hexblade's Curse" doesn't add critical damage to disadvantage rolls (Roll20 only)
Describe the bug Normally, when using the Hexblade's Curse, one can do critical Damage on a roll of 19+. At least in Roll20, it doesn't show the additional critical damage when rolling with disadvantage. Honestly I can't blame it, nobody would expect it.
To Reproduce Steps to reproduce the behavior:
- Go to Beyond20 Options
- Enable "The Hexblade: Hexblade's Curse"
- Roll Attacks until it critical hits with a 19+ (you need a lot of luck, like me)
- See output in roll20
Expected behavior A damage Value + Crit + Hexblade's Curse bonus damage
Screenshots
Step 1. / 2.
Step 3.
Step 4. (Roll20)
Browser Info (please complete the following information):
- Browser: Firefox
- Version: 87.0
The critical damage, since I rolled a 19 with Hexblade's curse (Crit on 19&20).
Normal crit looks normally like:
Oh, you have it rolling both damages (Versatile).
Can you verify this happens with only one-handed or only two-handed?
I added a screenshot, showing a normal crit when "Hexblade's Curse" is disabled. And here is an Advantage roll with Hexblade's Curse enabled:
So basically it is missing Crits in the sent "Disadvantage" info. And, if one is picky, the Hexblade's Curse damage on the Onehanded side, if you use "Show both Versatile"-Option.
Then it may be related to the extended critical range. Not sure. It is honestly pretty hard to roll that, so it is quite niche.
@kakaroto I'm struggling to find where the critical processing is taking place for this... Got any direction on that?
Know what's not fun? Rolling a ton of rolls to replicate this on DnDBeyond ONLY (which I just did).
So this does not happen on DnDBeyond (only), or FoundryVTT, so this is a Roll20-only bug.
I'll ask @kakaroto again, but this might be a Roll20 issue... Maybe around weird rollhandling by them of cs (consider success)?
I'll ask @kakaroto again, but this might be a Roll20 issue... Maybe around weird rollhandling by them of cs (consider success)?
yeah, that's what it sounds to me. The fact that the roll was green meant it recognized it as being a crit, but it still didn't display the crit damage. With the roll20 template, we always put the crit damage and roll20 decides if it should show it or not, so it sounds to me like it's a roll20 bug. Note: If you're using the digital dice, then it might be a Beyond20 bug since the rolls are made on Beyond20, not on roll20 and we're the ones deciding which damages should be shown.. but the output would look different in that case, so I don't think digital dice are enabled here.
I'll ask @kakaroto again, but this might be a Roll20 issue... Maybe around weird rollhandling by them of cs (consider success)?
yeah, that's what it sounds to me. The fact that the roll was green meant it recognized it as being a crit, but it still didn't display the crit damage. With the roll20 template, we always put the crit damage and roll20 decides if it should show it or not, so it sounds to me like it's a roll20 bug. Note: If you're using the digital dice, then it might be a Beyond20 bug since the rolls are made on Beyond20, not on roll20 and we're the ones deciding which damages should be shown.. but the output would look different in that case, so I don't think digital dice are enabled here.
I ran all my tests with Digital Dice off, and got the same results, so it does indeed sound like a Roll20 issue.
Note: It is REALLY hard to get into this state. Really hard...
Note: It is REALLY hard to get into this state. Really hard...
Really? I would expect it to be super easy to run into such a state.. it's what? one in 10 chances or something, right ?
Note: if you need to retry it, I'd recommend doing a quick stealthy edit of the code to make hexbalde's curse drop the crit limit to 2 instead of 19... that would make it much easier to test... also, sorry for not telling you before, but I just caught up on this issue! 🤣
I've retested this and it looks like Roll20 have fixed their bug. I got a 19 rolling with advantage with hexblade curse enabled and the crit damages were output correctly! 👍 🥳
