Rasmus Kaj

Results 125 comments of Rasmus Kaj

There's still not much discussion here. Maybe that's because there isn't that much to discuss? Is there any actual downsides to replacing the current run-time checks in the builder patterns...

> @kaj how would this play out with #442, #454? Could you cross review? I think there is no relevant conflict. #442 has `Builder2::status(code)` which takes a `StatusCode` rather than...

One way forward might be to set a flag in the decoder _before_ attempting to decode the file. If the flag is set, you get an error and no image,...

It's similar at least in that it is a small file claiming to encode a very large (65503x65503 pixel, in this case) image. I may have sounded a bit dissmisive...

I can't seem to get an image from the filedropper link. Did it expire? Update: There is a working image link in image-rs/image#738 .

The important thing here is consistency. Currently, the `image` crate does not apply rotation, and when I read the exif I find that I should apply rotation. I think that...

> I didn't notice that example but in any case it gets cloned each time right? It does, kind of. But the thing getting cloned is only an `Arc`, where...

> I agree with what has been mentioned before, it would be nice > > * if there would be a way to not always go through all filters (like...

The whole reason for the `Sealed` trait is to not be public. _If_ we want to make it possible to impl `AsLocation` for other types (which I agree would be...

Also, redirection to a location with a fragment identifier can be done, just not as simple. Example: https://github.com/kaj/r4s/blob/5c127de04188b6d9d733fa02a84504fc1dfe0eb4/src/server/mod.rs#L567-L571