kaizenflow icon indicating copy to clipboard operation
kaizenflow copied to clipboard

On-board Neha Pathak

Open samarth9008 opened this issue 1 year ago • 10 comments

Please follow this checklist. Post any errors you face in this issue.

The one in bold are really imp. Make sure to internalize them

FYI @sonaalKant @gpsaggese

samarth9008 avatar Apr 22 '24 12:04 samarth9008

Hey Samarth,

Good afternoon!

Thanks again for this detailed mail will go through these links.

Have a wonderful rest of your day!

Regards Neha Pathak

neha2801-create avatar Apr 22 '24 18:04 neha2801-create

Pls use Github GUI for conversation. With mail it adds unwanted info.

samarth9008 avatar Apr 22 '24 19:04 samarth9008

Under Point : How to do a review Clicking on Link: At page: https://github.com/kaizen-ai/kaizenflow/blob/master/docs/coding/all.submit_code_for_review.how_to_guide.md#read-python-style-guide Link is : Python Style Guide: it doesn't open proper page image image

Kindly let me know the alternative link if any.

neha2801-create avatar Apr 25 '24 17:04 neha2801-create

Good job finding it

It should be this link - https://github.com/sorrentum/sorrentum/blob/master/docs/coding/all.coding_style.how_to_guide.md

Can you create a PR with this correction?

samarth9008 avatar Apr 25 '24 17:04 samarth9008

Thanks @samarth9008, May I know what steps should i follow for this PR?

neha2801-create avatar Apr 25 '24 18:04 neha2801-create

https://github.com/kaizen-ai/kaizenflow/blob/master/docs/onboarding/kaizenflow.set_up_development_environment.how_to_guide.md#writing-and-contributing-code

samarth9008 avatar Apr 25 '24 18:04 samarth9008

May I raise this PR after 6 pm, since currently I am not working. I will rejoin post 6 pm.

neha2801-create avatar Apr 25 '24 18:04 neha2801-create

No worries take your time

samarth9008 avatar Apr 25 '24 18:04 samarth9008

Hi @samarth9008 , I have completed all required tasks. Now can you assign me the warm of issue. Thanks!

neha2801-create avatar Apr 26 '24 23:04 neha2801-create

Assigned

https://github.com/kaizen-ai/kaizenflow/issues/786

samarth9008 avatar Apr 26 '24 23:04 samarth9008

Closing as done

samarth9008 avatar May 16 '24 12:05 samarth9008