On-board Neha Pathak
Please follow this checklist. Post any errors you face in this issue.
- [x] Acknowledge the pledge to put time in the project here
- [x] Read How to organize your work
- [x] Read Quick start for developing
- [x] Make sure the Docker dev container works and read about our docker methodology
- [x] Make sure the unit tests run successfully
- OK if some are failing while running it
- [x] Read Sorrentum Python coding style guide
- [x] Fork, star, watch the Sorrentum repo so that GitHub promotes our repo (we gotta work the system)
- [x] Get assigned a warm-up issue
- [x] Learn about the Morning Email
- [x] How to do a review
- [x] If you are graduating soon and you would like to get a full-time job in one of the companies in the KaizenFlow ecosystem reach out to GP at [email protected]
The one in bold are really imp. Make sure to internalize them
FYI @sonaalKant @gpsaggese
Hey Samarth,
Good afternoon!
Thanks again for this detailed mail will go through these links.
Have a wonderful rest of your day!
Regards Neha Pathak
Pls use Github GUI for conversation. With mail it adds unwanted info.
Under Point : How to do a review
Clicking on Link:
At page:
https://github.com/kaizen-ai/kaizenflow/blob/master/docs/coding/all.submit_code_for_review.how_to_guide.md#read-python-style-guide
Link is : Python Style Guide: it doesn't open proper page
Kindly let me know the alternative link if any.
Good job finding it
It should be this link - https://github.com/sorrentum/sorrentum/blob/master/docs/coding/all.coding_style.how_to_guide.md
Can you create a PR with this correction?
Thanks @samarth9008, May I know what steps should i follow for this PR?
https://github.com/kaizen-ai/kaizenflow/blob/master/docs/onboarding/kaizenflow.set_up_development_environment.how_to_guide.md#writing-and-contributing-code
May I raise this PR after 6 pm, since currently I am not working. I will rejoin post 6 pm.
No worries take your time
Hi @samarth9008 , I have completed all required tasks. Now can you assign me the warm of issue. Thanks!
Assigned
https://github.com/kaizen-ai/kaizenflow/issues/786
Closing as done