Conv-TasNet icon indicating copy to clipboard operation
Conv-TasNet copied to clipboard

Cannot get the same evaluation SI-SNRi, even if using the pretrained model

Open deciding opened this issue 4 years ago • 4 comments

Hi, thanks for the code and the pretrained model, they really help me a lot!

When I trying to use your pretrained model provided in the link pan.baidu.com/s/1-Rqm7GwpV7Cc1XzHSpHROg, I found that, when running the evaluate.py, the result is very different from your evaluate.log. In the evaluate.log, it appears "Average SISNR improvement: 15.45" However, when I run it, it is around 9.8

I assume that, we should have the same json files in data/tt/. In this case, we have the same code and same weights, we should have the same SISNRi 15.45. I am wondering what makes the difference. Could I know the commit id of your repo when you run the evaluate.py. And could I have a look at your data/tt/mix.json(maybe just the starting 10 lines)

Below are the first few lines of my data/tt/mix.json [ [ "datasets/data/wsj0-mix/2speakers/wav8k/min/tt/mix/445c0206_0.60431_22gc0105_-0.60431.wav", 33301 ], [ "datasets/data/wsj0-mix/2speakers/wav8k/min/tt/mix/420c020h_1.1139_442c0203_-1.1139.wav", 51541 ], [ "datasets/data/wsj0-mix/2speakers/wav8k/min/tt/mix/22go0107_0.079969_051c010u_-0.079969.wav", 30391 ], [ "datasets/data/wsj0-mix/2speakers/wav8k/min/tt/mix/444o0314_2.1819_053o020e_-2.1819.wav", 25624 ], [ "datasets/data/wsj0-mix/2speakers/wav8k/min/tt/mix/423o0304_1.419_420c020x_-1.419.wav", 48961 ], [ "datasets/data/wsj0-mix/2speakers/wav8k/min/tt/mix/423o030b_1.4753_053o0209_-1.4753.wav", 44774 ], [ "datasets/data/wsj0-mix/2speakers/wav8k/min/tt/mix/441o030o_1.9903_445c020y_-1.9903.wav", 26795 ], [ "datasets/data/wsj0-mix/2speakers/wav8k/min/tt/mix/22ga010u_0.43921_443o030l_-0.43921.wav", 45120 ],

If this is not our difference, what other possibilities are there? Thanks!

deciding avatar Dec 29 '19 08:12 deciding

I can't visit my json files anymore. Maybe you can check your librosa version?

kaituoxu avatar Dec 30 '19 02:12 kaituoxu

I can't visit my json files anymore. Maybe you can check your librosa version?

Thanks for the hint. Can I have a look at your conv-tasnet pip freeze? maybe I can have a check on it?

deciding avatar Dec 30 '19 02:12 deciding

I can't visit my json files anymore. Maybe you can check your librosa version?

Thanks for the hint. Can I have a look at your conv-tasnet pip freeze? maybe I can have a check on it?

Hi deciding,

Have you solved this problem? Because I have this problem too. Thanks!

Tinglok avatar Feb 07 '20 13:02 Tinglok

So apparently, WSJ has two version of each file - .wv1 & .wv2 one is a noisier version of the another. use the clean ones and then you be able to reproduce the results.

enk100 avatar Feb 07 '20 13:02 enk100