pcap4j icon indicating copy to clipboard operation
pcap4j copied to clipboard

Published 20 hours ago • verified publisher icon kaitoy

Issue #110 - Probe Request Information Element Order change

Open sandeepkumarnv opened this issue 8 years ago • 5 comments

Please review these initial version of changes. Since I have to iterate inside the header elements constructor I am forced to take out the "final" declarations on information elements. I didn't want to do that though. Please take a look at this and let me know your thoughts on it. Also I have not worked on factory implementation yet. I will be working on that soon. Thanks

sandeepkumarnv avatar Jul 12 '17 16:07 sandeepkumarnv

Coverage Status

Coverage increased (+0.09%) to 70.393% when pulling 584d14e3cf5812f522bfd7977ee9cd6bd944db55 on sandeepkumarnv:v1 into db6a43f3dd134bfb4db65810eaf6ba901ee7af1d on kaitoy:v1.

coveralls avatar Jul 12 '17 16:07 coveralls

Thank you for your PR. I will take a look at it.

kaitoy avatar Jul 18 '17 13:07 kaitoy

Please let me know your feedback on this when you get a chance to review. Thanks

sandeepkumarnv avatar Aug 05 '17 00:08 sandeepkumarnv

I'm also very interested in this and would love to help if necessary.

lennartkoopmann avatar Aug 05 '17 23:08 lennartkoopmann

Sorry for my late response. Currently I don't have enough time for Pcap4J... Actually, this PR has some problems. I will explain them tomorrow.

kaitoy avatar Aug 06 '17 15:08 kaitoy