cs431 icon indicating copy to clipboard operation
cs431 copied to clipboard

[Homework 5] Hash Table (due: 2022-12-19 23:59:59)

Open Lee-Janggun opened this issue 2 years ago • 19 comments

Implement a concurrent lock-free Hash Table.

  • Read this manual for general advice on homework.

  • Documentation & Tips.

  • Use skeleton code as a starting point, and fill out todo!().

    • IMPORTANT: don't fork this repository. It'll be public!
  • Submit your code here. You can create the zip to submit as follows:

    cd cs431/homework
    ./scripts/submit.sh
    ls ./target/hw-hash_table.zip     # file to submit
    

Lee-Janggun avatar Aug 31 '22 14:08 Lee-Janggun

@Lee-Janggun Link in documentation is not working. Could you check it?

jeong0982 avatar Sep 05 '22 01:09 jeong0982

@jeong0982 I updated the links. Can you check again?

Lee-Janggun avatar Sep 05 '22 01:09 Lee-Janggun

@Lee-Janggun It is working now. Thanks.

jeong0982 avatar Sep 05 '22 01:09 jeong0982

We have updated the grading script to partially allow SeqCst ordering. You will still need to use more relaxed orderings to get full points.

Lee-Janggun avatar Sep 20 '22 07:09 Lee-Janggun

I forgot to mention it above, but since the grading script has changes, all previous submissions are nullified, so please submit again.

Assignments that had gotten full scores before should still get full points.

Lee-Janggun avatar Sep 22 '22 06:09 Lee-Janggun

I resubmitted my answer and found that Success? status in gg website is stuck with Checking... state even if Score: 180 / 180 is shown at the bottom of the log. (This happens only in homework 5, not in homework 6)

Could you please check this problem? Thank you in advance.

kingdoctor123 avatar Sep 22 '22 13:09 kingdoctor123

@kingdoctor123

  1. can you send me your code to [email protected] so that I can have a look?
  2. does the problem also happen locally?

Lee-Janggun avatar Sep 22 '22 14:09 Lee-Janggun

@Lee-Janggun

  1. I sent the mail right now. So could you please check it?
  2. I'm now running test on local machine, and I'll let you know when it is done.

kingdoctor123 avatar Sep 22 '22 14:09 kingdoctor123

@Lee-Janggun For question 2, it seems there's no problem when I run the test on local machine.

kingdoctor123 avatar Sep 22 '22 15:09 kingdoctor123

@kingdoctor123 I can confirm that both yours and the model solution does not work. We'll fix it ASAP.

Lee-Janggun avatar Sep 23 '22 02:09 Lee-Janggun

Update: https://github.com/kaist-cp/cs431/commit/5f7d611d4a4d3a87e2fead4a76d63adfe08c547c made the previously unsafe Cursor::from_raw() into a safe Cursor::new(), as we realized there was no reason to make this unsafe.

This is a breaking change, and as we expected split_ordered_list.rs to use this API, all previous solutions will probably not work. Please adapt to this change.

Lee-Janggun avatar Sep 23 '22 04:09 Lee-Janggun

@kingdoctor123 We updated the grading script to be more efficient. Can you try again?

Lee-Janggun avatar Sep 23 '22 07:09 Lee-Janggun

@Lee-Janggun I tried it once more, but I'm still having the same problem.

kingdoctor123 avatar Sep 23 '22 07:09 kingdoctor123

@kingdoctor123 I tried submitting your code to gg and it worked. Can you try again?

Lee-Janggun avatar Sep 23 '22 10:09 Lee-Janggun

@Lee-Janggun Now it works well. Thank you so much for your help.

kingdoctor123 avatar Sep 23 '22 10:09 kingdoctor123

I think there is the same issue with https://github.com/kaist-cp/cs431/issues/619#issuecomment-1255041987. The log prints score, but SUCCESS? is Checking.... Thank you for all your assistance.

kangwon avatar Oct 25 '22 14:10 kangwon

@kangwon does re-submitting also not work?

Lee-Janggun avatar Oct 25 '22 14:10 Lee-Janggun

(I guess) it depends on the score. When some tests are failed, the SUCCESS? becomes Yes. But when all tests are succeed, the SUCCESS? is not changing.

For several tries, all passes were all SUCCESS? Checking... and otherwise all SUCCESS? Yes.

kangwon avatar Oct 25 '22 14:10 kangwon

@kangwon Please send me your code to [email protected].

Lee-Janggun avatar Oct 25 '22 14:10 Lee-Janggun

I think there is the same issue with #619 (comment)....

The symptom has been gone now. Thanks to manage the issue!

kangwon avatar Nov 09 '22 04:11 kangwon