Tomas Tormo

Results 36 comments of Tomas Tormo

> /retest I thought I couldn't do this here since the repo uses GH actions... 🤦🏻

> @kaisoz: Cannot trigger testing until a trusted user reviews the PR and leaves an `/ok-to-test` message. @astefanutti prow doesn't trust me 😆 . I did run the clone line...

> @kaisoz there is an issue with CI that should be fixed after you rebase this on top of #3023. great @astefanutti ! Thanks! Then I think I'll wait for...

@astefanutti all green now! PTAL whenever you have time. Thanks! 🙂

> @kaisoz that looks good to me overall, thanks! > > I understand the webhook would automatically set the manager field to "mimic" SSA behavior, but just to be sure...

> I like the idea of defaulting the manager to req.UserInfo.Username if it is empty, however will it introduce any problems in the future if we decide to make PodTemplateOverrides...