kairos icon indicating copy to clipboard operation
kairos copied to clipboard

macOS cli binary

Open renanqts opened this issue 3 years ago • 2 comments

First of all, thanks for the very nice project.

Currently, there is no such version for darwin binary (macOS users). Can we please add to the build process?

renanqts avatar Jul 01 '22 19:07 renanqts

Do you see any other change apart from appending this list here?

https://github.com/c3os-io/c3os/blob/11158a12aa13b5181f9c16a5718db63b89a2f40b/.goreleaser.yaml#L7-L9

renanqts avatar Jul 01 '22 20:07 renanqts

That's a good point, thanks for opening this up.

Last time I've checked there where some deps that weren't compatible with Darwin. I've take care of edgevpn, so now compiles on Darwin just fine.

But yup, change-wise that should be it to enable Darwin builds

mudler avatar Jul 02 '22 12:07 mudler

What we could do here is disable screenshots on macOS as that doesn't builds statically - at least we could feed it with an image. thoughts @jimmykarily ?

mudler avatar Nov 19 '22 23:11 mudler

What we could do here is disable screenshots on macOS as that doesn't builds statically - at least we could feed it with an image. thoughts @jimmykarily ?

Disabling screenshots is one approach. The other alternative would be to build a non static binary for macos. After all, that binary is not supposed to run in a container (these are all linux right?) so the dynamic libraries will be in place.

jimmykarily avatar Nov 21 '22 08:11 jimmykarily

What we could do here is disable screenshots on macOS as that doesn't builds statically - at least we could feed it with an image. thoughts @jimmykarily ?

Disabling screenshots is one approach. The other alternative would be to build a non static binary for macos. After all, that binary is not supposed to run in a container (these are all linux right?) so the dynamic libraries will be in place.

True, however when I've tried that IIRC the screenshot lib requires some x code libs. I'm not a MacOS expert to be able to judge, but guess would take us to some hops

mudler avatar Nov 21 '22 08:11 mudler

What we could do here is disable screenshots on macOS as that doesn't builds statically - at least we could feed it with an image. thoughts @jimmykarily ?

Disabling screenshots is one approach. The other alternative would be to build a non static binary for macos. After all, that binary is not supposed to run in a container (these are all linux right?) so the dynamic libraries will be in place.

True, however when I've tried that IIRC the screenshot lib requires some x code libs. I'm not a MacOS expert to be able to judge, but guess would take us to some hops

Not an MacOS expert here either. Maybe it's just about documenting the dependencies...

jimmykarily avatar Nov 21 '22 08:11 jimmykarily

Hi @renanqts , we are steering away to require any CLI with https://github.com/kairos-io/kairos/issues/772 - so I think this issue might be not needed anymore. Do you think it would be enough and satisfy your use-cases?

mudler avatar Feb 07 '23 10:02 mudler

Hey.

No no, we can close it. Thanks

renanqts avatar Feb 07 '23 17:02 renanqts