kairos
kairos copied to clipboard
kairos-io
Fix device json schema to allow other device paths
After this: https://github.com/kairos-io/kairos-agent/pull/552 we should now update the schema to allow these new paths: https://github.com/kairos-io/kairos-sdk/blob/156caa6f8c9066b99417912a572285c33ab44b3c/schema/install_schema.go#L14
Auroraboot fails with this if we don't:
Target OSs /etc/systemd/system/cloud_init.yaml does not pass validation. Quitting.
jsonschema: '/install/device' does not validate with file:///schema.json#/properties/install/$ref/properties/device/pattern: does not match pattern '^(auto|/|(/[a-zA-Z0-9_-]+)+)$'
Hi, can I work on this bug?
By all means @HariniKrishnan! Give it a shot. If it takes too long we may have to pick it up within the core team to unblock people though.
@jimmykarily When are we expecting the code, can I take a week's time?
@jimmykarily When are we expecting the code, can I take a week's time?
Sure thing @HariniKrishnan ! Thank you :100:
@HariniKrishnan I'll assign you to the ticket, it's not to put any pressure but just to also see it on the dashboard that someone is on it. If you need help or more time, just let us know. Thanks!
@HariniKrishnan I'd say the slack channel is probably the best place because then whoever in the team looks at it and knows, can start helping. Just keep in mind for the replies that we are mostly in EU timeline
[email protected] is my email!!! can you please add me to you workspace!
You need to get a self-invitation here: https://slack.cncf.io/#kairos
Hey @jimmykarily Any idea when this might get fixed? Thanks!
We planned it for the last sprint but nobody got a chance to fix it. Let's hope we get this done this week.
The fix got merged in the kairos-agent. We just need to cut a new release of kairos-agent and kairos to make it consumable.
@jimmykarily, did this get released in 3.2.2? I don't see a mention of it so I'm assuming not.
@jimmykarily, did this get released in 3.2.2? I don't see a mention of it so I'm assuming not.
Yes the fix is in 3.2.2, I updated the release notes to say so (the first item in the list).
@jimmykarily, did this get released in 3.2.2? I don't see a mention of it so I'm assuming not.
Yes the fix is in 3.2.2, I updated the release notes to say so (the first item in the list).
sorry, we did a mistake and we didn't bump the kairos-agent in the latest framework image :facepalm: . Please wait for 3.2.3 (coming soon)
This should be fixed. I'll close but feel free to re-open if you face any issues.
@jimmykarily This isn't working for us quite yet.
Our config has this in it
install:
device: "/dev/disk/by-path/pci-0000:03:00.0-scsi-0:0:0:0"
Error at the console:
Looks like it is adding a p1 at the end of the device path.
Is this intentional or a bug?
Edit: This is Kairos v3.2.4 built by and booting from AuroraBoot v0.4.3
The WARNING report a pattern that is not matching the fixed one: https://github.com/kairos-io/kairos-sdk/blob/d334d86d4369929e47d569d9d8a6eeb4698e55ca/schema/install_schema.go#L14
It should use the new "^(auto|/dev/.+)$" but it's reporting the old one.
You need kairos-agent >= v2.15.4 to get this fix. The logs report kairos-agent v2.13.9.
This can't be kairos v3.2.4.
Wellllll . . . That's because someone . . and I'm not gong to name names here . . forgot to actually build the new image and, you know, use it.
It was me, I did it.
Sorry.