Zhenghua Lyu

Some comments: 1. can `update|delete|insert` benefited by this idea? 2. can we make the function `checkNeedDistributedSnapshot` a `static bool`

> 1. No, because `update|delete|insert` will not use `PORTAL_ONE_SELECT` strategy. Can we take a look at which strategy they use and if we can use the same idea there.

So sorry for long time no review. @hughcapet Thanks a lot for your contribution. Rought reading the code, seems fine. Will spend more time on this later.

Code change seems fine. Lazy question on some history: do you know why it is changed to `char` ?

Hi would you please offer the 1. coredump 2. minirepro (doc how to use it https://community.pivotal.io/s/article/How-to-Collect-DDL-and-Statistics-Information-Using-the-Minirepro-Utility?language=en_US)

Can you paste the plan that lead to PANIC here?

In my local env, planner's plan seems OK (semi join): ```sql -- with distinct QUERY PLAN -------------------------------------------------------------------------------------------------- Gather Motion 2:1 (slice2; segments: 2) (cost=3.17..3.18 rows=1 width=66) -> HashAggregate (cost=3.17..3.18 rows=1...

Thanks for your PR and the reproduce SQL in your script. I have played with the issue for just a little time, and give the following patch (just demo play...

Thanks. Will spend time in reviewing this later.

Code change LGTM. Thanks. Several comments: 1. the title is select xxx returning, it is a typo? 2. I see this issue reproduce with UPDATE (I see the trigger is...