Kai-Hsin Wu
Kai-Hsin Wu
Does it actually settled up on action? I thought its there. And it was fine before tho, so I am confused On Sun, Sep 15, 2024, 01:22 Ivana ***@***.***> wrote:...
If it's optional requirements for format I'd say we don't worry about it and follow as much as std. Google style is good but it has too much historical burdens...
Yes I know. We set up this. My point is if there is no issue with clang formatter then I don't think we should care about the format even it...
Feel free to close this issue if you think we are going to stick with Google style. On Sun, Sep 15, 2024, 01:54 Kai-Hsin Wu ***@***.***> wrote: > Yes I...
Make sure you staging the progress into multiple PRs instead of making a big one for all modification. Other than that LGTM so far
@IvanaGyro Let me know if you hit a point where the refactor is ready. I want to start moving Storage + Tensor into another repo cytnx-core
I want to keep the wrapper class (Tensor and Storage) from their impl. We will need to separate the package for a few strategy reasons. On Sat, Sep 14, 2024,...
> It's fine to leave Tensor and Storage as abstract classes apart from their implementation. > > I wonder what are the reasons for splitting the repo? What are the...
All GPU, CUDA kernels for Tensor (and below) should go to cytnx-core
> It's fine to leave Tensor and Storage as abstract classes apart from their implementation. > > I wonder what are the reasons for splitting the repo? What are the...