edamagit icon indicating copy to clipboard operation
edamagit copied to clipboard

Published 20 hours ago • verified publisher icon kahole

Amend does not show full changelist

Open cab404 opened this issue 2 years ago • 4 comments

It copies the message, but creates a regular commit.

cab404 avatar Nov 21 '21 23:11 cab404

Unable to reproduce. Please expand

kahole avatar Nov 22 '21 14:11 kahole

Unable to reproduce. Please expand

Sure. Version v0.6.24, from OpenVSX. In any repo I've tried, the following reproduces:

  1. Add something to staging area
  2. <C> <A>
  3. Changeset has only staged changes, and creates a new commit after a confirmation.

cab404 avatar Nov 22 '21 15:11 cab404

Sorry, one more thing. Post your magit log? Pressing $ from the status view brings it up

kahole avatar Nov 22 '21 16:11 kahole

Oof, sorry about that :sweat: A chain of accidents led me to this report:

  1. Magit always shows full resulting commit, not only the added changes. D:
  2. It's probable that I've managed to launch a regular commit with commit message from --amend commit, but nontheless I've ended up with two commits with same message
  3. Since I've been testing this on repositories I frequently work on, I only took in account my first attempt at reproducing the issue

That led me to believe that this is an error in amending. Sorry :(

Nonetheless, it would be nice to have full list of staged changes in an amend, image image

cab404 avatar Nov 23 '21 10:11 cab404