goofys icon indicating copy to clipboard operation
goofys copied to clipboard

Update azure dependencies to recent, stable version

Open philwinder opened this issue 3 years ago • 2 comments

The dependencies listed in the go.mod are pointing to azure libraries that have interfaces that goofys won't work with.

This PR updates the code to use the correct interfaces (I defaulted to empty options, this may not be appropriate) and then I could update the library versions to the most recent.

This fixes #664 and similar build issues.

philwinder avatar Feb 28 '22 09:02 philwinder

@philwinder do you have a peer that can review and run the tests for these changes? I think its a case of running CLOUD=azblob make run-tests with the correct credentials configured as well. I don't have access to an Azure account nor the context at the moment to review changes for Azure back-end.

run-tests.sh shows some environment variables that can be set to configure for Azure: https://github.com/kahing/goofys/blob/c6e678cc66390198b28d66144d513f0b93ac5b65/test/run-tests.sh#L46-L66

I'm hoping we can get this PR reviewed by a member of the community, then final review and merge from Ka-Hing, allowing users to build and install Goofys using go install.

dannycjones avatar Jun 28 '22 16:06 dannycjones

Would it be possible for you to rebase to pick up the update to the fuse lib in 829d8e5ce20faa3f9f6f054077a14325e00e9249?

Currently we see the following error when building, which seems related to the FUSE lib updated in that commit. When I rebase on top of 829d8e5ce20faa3f9f6f054077a14325e00e9249, build is OK.

$ make build
go build -ldflags "-X main.Version=`git rev-parse HEAD`"
# github.com/kahing/goofys
github.com/jacobsa/fuse/internal/buffer.memclr: relocation target runtime.memclrNoHeapPointers not defined for ABI0 (but is defined for ABIInternal)
make: *** [Makefile:13: build] Error 2

dannycjones avatar Jun 28 '22 16:06 dannycjones

closing via cc76eec5841f7bbf499e21d97f91a01e2e2f5af0

kahing avatar Nov 03 '22 18:11 kahing