goofys
goofys copied to clipboard
kahing
Go Modules and the forked gofuse
I have run into some problems when trying to build and make changes to goofys. Some of which would be solved by the use of Go Modules instead of the way sub-packages are being used now. Locally, I have made a goofys a go module and updated all the references for "fuse" to go to the forked "gofuse". Is the intention to merge the forked gofuse back into the "fuse" project? Would you be receptive to taking changes that just migrate to using Go Modules and directly gofuse instead of having gofuse run in disguise as "github.com/jacobsa/fuse"?
@kahing just wondering if you have thoughts here. Should I just put out some PR's?
There was another PR https://github.com/kahing/goofys/pull/462 that did this. I've never used go mod at the time and sort of let it gather dust. I've since started using go mod for another project and happy to take an updated PR for this.
wrt gofuse, yes the intention is to submit the existing changes upstream, but unfortunately I never got around to do that.
@kahing , ok, I will look at what I can do to make a new PR with using mod. I have it working in a branch, but I also had to make a local branch of gofuse so that it wasn't a weird overwrite scenario. I think there may be a way around that. However, if you could get your changes back to mainline "github.com/jacobsa/fuse" it would be much better of course.
@kahing I created a PR for this. https://github.com/kahing/goofys/pull/555
@ebressler Thanks for the contrib, it solved my issues building! I merged your PR #555 in my fork, and included a 2-way merge update for fuse in my fuse fork, which solved incompatibilities and building for arm and arm64. It appears to work now even on an old arm NAS (not done real transfer tests yet).
@ppenguin good to hear that it is working for somone else as well. Hopefully @kahing will get some time to put this into the main tree soon. Keep me posted if you run into any issues related to it.
@kahing Hey there, I have a couple of outstanding PR's. Wondering if there is something that you need from me to get them merged and into a release.
Because of @ppenguin's work I was finally able to cleanly use goofys in my project. Thanks!
