gnome-shell-extensions-pidgin icon indicating copy to clipboard operation
gnome-shell-extensions-pidgin copied to clipboard

Update to work with Gnome Shell 3.6

Open ghost opened this issue 13 years ago • 19 comments

ghost avatar Oct 15 '12 18:10 ghost

olibjerd, why this commit? it doesn't fix anything.

ildar avatar Oct 16 '12 05:10 ildar

Just changing the version does not make this work with 3.6:

JS LOG: Extension "[email protected]" had error: Error: No JS module 'telepathyClient' found in search path

l300lvl avatar Oct 16 '12 05:10 l300lvl

i'm not on gnome 3.6 yet .. but from what l300lvl mentioned .. got a feeling that this plugin might need a major update ..

js module telepathyClient no longer around? >.<

kagesenshi avatar Oct 16 '12 06:10 kagesenshi

Well after looking closer the location has changed:

const TelepathyClient = imports.ui.telepathyClient;

becomes

const TelepathyClient = imports.ui.components.telepathyClient;

so it isn't gone and with this change the extension does enable, but it doesn't work, and there are other major changes to the module which need worked out

l300lvl avatar Oct 16 '12 06:10 l300lvl

ah ok then .. thanks l300lvl ..

i'll poke on this once i'm on Fedora18beta/gnome3.6 ..

F18beta should be out around end of this month ..

kagesenshi avatar Oct 16 '12 06:10 kagesenshi

Thanks for looking into this. Waiting for your extension to work in gnome shell 3.6 :)

rajeshksv avatar Oct 18 '12 10:10 rajeshksv

I dig into the source and work out a merely working version at my fork, not perfect at all, and only works for 3.6(considering those grate changes brought by upstream api.)

https://github.com/pentie/gnome-shell-extensions-pidgin/commit/6d9690d3e5b34f5f1c019d6e8f136d839816e0a7

boypt avatar Oct 26 '12 07:10 boypt

update those ICON thing. https://github.com/pentie/gnome-shell-extensions-pidgin

The gnome-shell code is too complicated, i don't know how to pull avatar from pidgin, I let it be the default one.

The unread counter not working (yet)

And My version ONLY works for 3.6, thus I think not to pull request to @kagesenshi at the moment, it's better to branch them in the repository, the 3.6 API changes and it's difficult to make it work with all versions.

boypt avatar Oct 26 '12 08:10 boypt

@pentie works for me for now, thanks a lot

olebowle avatar Nov 08 '12 14:11 olebowle

any news @kagesenshi ? I really love this extension

alcuadrado avatar Dec 18 '12 19:12 alcuadrado

try to use this fork => https://github.com/thedeadparrot/gnome-shell-extensions-pidgin/commits/master

marcelometal avatar Dec 20 '12 20:12 marcelometal

@marcelometal why don't you send a pull request or something? This definitely works!


EDIT

When you type in the message in the popup, it's not marked as read, hence notification icon ain't updated (keeps blinking). Which is a bugger. =/

aL3xa avatar Mar 18 '13 20:03 aL3xa

@pentie Unfortunately I can't open issues on your forks page, that's why I'm putting it here. I updated to gnome3.8 today. Your fork won't start even though I changed the shell-version in metadata.json to 3.8. The error message is: Error: No JS module 'dbus' found in search path

olebowle avatar Apr 22 '13 12:04 olebowle

seems like i myself havent got around to fix this .. too busy with work Plone stuff ..

any of the forks are working well? .. i can give direct access to here if there are people who are interested in continuing maintaining this ..waiting for me might take a too long ..

kagesenshi avatar Apr 22 '13 12:04 kagesenshi

@olebowle I'm in gnome-shell 3.8 too but, I switched to empathy which I find had done a lot of improvement, it's more usable then ever.

The gnome-shell API is changing so much and the document is scarce, it's too harsh for me to keep this plugin working.

Hope someone else would do that ... :)

boypt avatar Apr 22 '13 13:04 boypt

I was hoping for the same. ;-)

olebowle avatar Apr 22 '13 19:04 olebowle

As for the dbus stuff a quick google revealed it has some big changes in 3.8, hopefully this may be of some help: https://github.com/aleho/hamster-shell-extension/commit/8b4ba78c5abe6616cbf68c82736d4898e9e2373c

l300lvl avatar Apr 22 '13 20:04 l300lvl

yeah .. every release the API for the TelepathyClient notification changed .. :( ..

probably this plugin need a new rewrite, so that it doesnt rely on TelepathyClient stuff ..

kagesenshi avatar Apr 23 '13 10:04 kagesenshi

Why did I only read this comment thread AFTER my pain of getting this 3.8 ready. It's in a separate pull request, but I haven't tested with 3.4 or 3.6.

Psykar avatar May 01 '13 05:05 Psykar