Kay Agahd

Results 33 comments of Kay Agahd

I've created a pull request which solves this issue. See https://github.com/mzupan/nagios-plugin-mongodb/pull/245

Hi @jfagoagas > Is this PR just picking the code from the PR I mentioned? Yes, it is. In this PR I took the code from PR #3962 and adapted...

> If you don't mind we prefer to do the backport in our way, Yes, of course. I thought I could help you by doing this to speed up the...

Hi @jfagoagas, thanks for your reply. Indeed, it would be great to cover these cases! Until now, we just have the three cases that I mentioned above. Here is an...

> What if we include these filters in the EC2 service while retrieving security groups? We can store the `InstanceOwnerId` of the network interface and the `InterfaceType` and include a...

The discussion continues here: https://github.com/prowler-cloud/prowler/discussions/4065

Hi @jfagoagas, > Maybe it'll be easier for now to save something within the EC2 service, what do you think? I preferred a separation of concerns by using the `state_manager`...

> Could you add a test for each check while checking that `ec2_client.is_failed_check()` returns true, thus no findings will be generated? Sure, I will add them later today.

> Could you add a test for each check while checking that `ec2_client.is_failed_check()` It's done.

Hi @jfagoagas could you please advise, why the `pr-lint-test` [tests](https://github.com/prowler-cloud/prowler/actions/runs/9174232628/job/25224637564?pr=4018) are failing after my last last commits from today? When I run them locally, only 2 of a total 3175...