kafka_ex
kafka_ex copied to clipboard
Enable graceful shutdown of a GenConsumer
Add a user-configurable :shutdown
to GenConsumer
's child_spec.
Addresses #434, if do_some_job
, from the referred issue, is either synchronous or async. Not sure if the change covers the case of a cluster rebalance.
@Argonus and @joshuawscott, I've been already using the proposed change, as the worker's (default) :shutdown
value of 5 s is, in my use, not long enough to let all messages in a message_set
be processed in time. Even though the proposed change is likely the smallest possible/needed to achieve a graceful shutdown, I might have missed something.
If you'll find time, any feedback, either affirmative or dismissive, would be much appreciated. (Especially given that I already went ahead and use this in production.)
@joshuawscott I've tested that on my own setup, it works well with different shutdowns time.