kafka4beam
Support Create Partitions
Adds in the ability to create partitions for an existing topic. Adds in the ability for clients to synchronize their topic metadata to pick up new partitions and start a producer.
thank you for the PR @BlueCollarChris could you add an entry in CHANGELOG.md
Just seeing the comments now and will get back to you on Monday. I had been exploring a different route locally where the sync is done outside the client in a linked genserver. I wasn't sure if the sync process were to block the client would be disrupted from handling other requests. I'll see about getting those changes up shortly.
@zmstone got the update in I mentioned over the weekend. Is there a specific formatter you recommend looks like the one for my IDE formatted some stuff showing more changes than were there previously. I did make the change to start the partition producer under the brod_supervisor3 as mentioned in your previous comment. Working on the tests for the brod_partitions_sync module still.
Hi @BlueCollarChris Thank you for the PR and sorry for the slow review.
About code format: we use https://github.com/WhatsApp/erlfmt example for ref: https://github.com/kafka4beam/brod-cli/blob/f8a2784f4ffb7aa70bf8006c2b519ca12991c4f7/rebar.config#L7-L10
Possible to leave code reformat out in this PR? it makes review easier.
I have been completely swamped but will get to updating the formatting of this very soon, sorry for the delay
Working on the formatting at this point to remove the changes and conform the new module to it
@zmstone This is now ready. I have removed the formatting changes from the code that was causing the delay from earlier.