brod icon indicating copy to clipboard operation
brod copied to clipboard

WIP: add telemetry

Open spencerdcarlson opened this issue 2 years ago • 5 comments

spencerdcarlson avatar Jun 18 '22 22:06 spencerdcarlson

Thanks for the PR.

BTW. I originally wanted a solution without {telemetry, "~> 1.0"} in the dependency (and the brod_use_telemetry to be undefined by default). So to push the responsibility to the wrapping project.

zmstone avatar Jul 08 '22 19:07 zmstone

I have changed the base to dev/telemetry let's start instrumenting the code, preferably increment with small PRs.

zmstone avatar Jul 08 '22 19:07 zmstone

This would be very nice to have. What is needed to get this in?

maxno-kivra avatar Oct 23 '23 07:10 maxno-kivra

:wave:  Also looking to help push this forward, @zmstone , how can I help?

akosasante avatar Nov 25 '23 01:11 akosasante

Use dependency injection. Have measurement points invoke a local, "virtual", telemetry module. That module checks if a telemetry callback module has been registered in the environment: if it has, pass the telemetry on to it, if not, do nothing. The end result is that this project has no hard-coded dependencies in any telemetry framework, but the user can hook one up via the callback module they control.

mikpe avatar Nov 25 '23 10:11 mikpe