julie icon indicating copy to clipboard operation
julie copied to clipboard

--dryRun should detect incompatible schemas

Open LeonardoBonacci opened this issue 4 years ago • 3 comments

This bug/enhancement is more of a general question.

Registering a schema works perfectly well. When an updated schema becomes/is made incompatible and another run is attempted, the --dryRun option does not detect this.

Without --dryRun, the danger is that topics configs ARE updated, while the incompatible schema throws the following just error message:

Schema being registered is incompatible with an earlier schema for subject "context.company.env.source.projectB.bar.avro-value

Now we have an intermediate state in which the cluster is not as described by any descriptor.yaml.

To reproduce, just use the basic example https://github.com/kafka-ops/julie/blob/master/example/descriptor-with-schemas.yaml and change one of the schema's.

Did I miss something or is this indeed the inevitable behavior?

LeonardoBonacci avatar Mar 07 '21 21:03 LeonardoBonacci

related to #102

purbon avatar Mar 08 '21 08:03 purbon

@LeonardoBonacci right now the dry run does not detect anything regarding schemas, but this is clearly an area of improvement for this component. I have linked both issues.

purbon avatar Mar 08 '21 08:03 purbon

Implemented by https://github.com/kafka-ops/julie/pull/254

LeonardoBonacci avatar Apr 06 '21 01:04 LeonardoBonacci