twig-language-server icon indicating copy to clipboard operation
twig-language-server copied to clipboard

Support more lsp features

Open aszenz opened this issue 2 years ago • 3 comments

Thanks for making this and improving the lives of twig developers.

Before using the vscode plugin I used https://marketplace.visualstudio.com/items?itemName=mblode.twig-language-2.

I'm missing some feature from it though:

  1. Twig snippets like these
do                {% do ... %}
extends           {% extends 'template' %}
from              {% from 'template' import 'macro' %}
  1. Support formatting maybe integrate with third party plugin like prettydiff
  2. Some form of go-to-definition (maybe for blocks and macros initially)

aszenz avatar Aug 27 '23 10:08 aszenz

Did you try to use the both extensions together? They shouldn't conflict.

kaermorchen avatar Aug 27 '23 13:08 kaermorchen

Did you try to use the both extensions together? They shouldn't conflict.

Yes i could use the snippets from the library, and use this library for syntax highlighting

aszenz avatar Aug 27 '23 15:08 aszenz

@aszenz

Some form of go-to definition

Implemented that here for include('template.html.twig') and other template inclusion statements/functions. https://github.com/kaermorchen/twig-language-server/pull/27

Please tell me if something is missing for this feature. PR review is welcomed.

moetelo avatar Sep 22 '23 11:09 moetelo