node-ignore icon indicating copy to clipboard operation
node-ignore copied to clipboard

fix: support file which named '...'

Open howel52 opened this issue 4 years ago • 3 comments

... or more then two dots may be a file

but throw Error like RangeError: path should be a path.relative()d string, but got "..." now.

howel52 avatar Jan 06 '21 03:01 howel52

Codecov Report

Merging #68 (fdfd710) into master (7cc95d2) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #68   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          129       129           
=========================================
  Hits           129       129           
Impacted Files Coverage Δ
index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7cc95d2...fdfd710. Read the comment docs.

codecov-io avatar Jan 06 '21 04:01 codecov-io

I'm really not quite sure about the compatibility cross different file systems.

I'm struggling in my head whether I should make the validation as a convention(warning) or not(error)

kaelzhang avatar Jan 06 '21 14:01 kaelzhang

yep, maybe we need another solution to solve this bug.

howel52 avatar Jan 07 '21 03:01 howel52