webrtc-vad icon indicating copy to clipboard operation
webrtc-vad copied to clipboard

Implement Send for `Vad`

Open andreytkachenko opened this issue 4 years ago • 5 comments

It should be safe to implement Send for Vad since Vad does not contain any Rc analogs and other non-sendable types

andreytkachenko avatar Jul 16 '20 10:07 andreytkachenko

I think the question is also whether the underlying C structs are Send.

The relevant structures in the C-Code are

https://github.com/dpirch/libfvad/blob/fdf039bd6a8d201b27175dccf8d85c003c2cf252/src/fvad.c#L32 https://github.com/dpirch/libfvad/blob/fdf039bd6a8d201b27175dccf8d85c003c2cf252/src/vad/vad_core.h#L26 https://github.com/dpirch/libfvad/blob/master/src/signal_processing/signal_processing_library.h#L80

which are basically only composed of integers without any connection to multi-threading. So I think there probably is no problem. Do you want a new version with this change?

kaegi avatar Jul 16 '20 16:07 kaegi

Thanks for you reply. I think version bump to 0.4.1 would be okay.

andreytkachenko avatar Jul 18 '20 20:07 andreytkachenko

Hi! It would be great to have some resolution on that PR. Thank you.

andreytkachenko avatar Aug 20 '20 15:08 andreytkachenko

Any chance of getting this done?

droundy avatar Apr 12 '22 11:04 droundy

Hey, is there any chance of doing it? I actually need this feature as I am planning to use it in async context with a mutex

srikarm99 avatar Aug 18 '24 09:08 srikarm99