MorphMan icon indicating copy to clipboard operation
MorphMan copied to clipboard

Bump maximum version to 2.1.53

Open yaoberh opened this issue 2 years ago • 11 comments

There are not breaking changes in 2.1.53 to modify this.

yaoberh avatar Jun 18 '22 19:06 yaoberh

Does it really works without problems with 2.1.53? The AnkiWeb page has this warning, and no update to MorphMan has been made since:

**Warning**
Anki 2.1.50 changed a lot of things under the hood, breaking compatibility with MorphMan.
Use version 2.1.49 in the meanwhile: https://github.com/ankitects/anki/releases/tag/2.1.49

CC: @ianki

rwmpelstilzchen avatar Jul 16 '22 09:07 rwmpelstilzchen

I didn't even see that notice! Haven't got any problems thus far, although they're probably hidden to me as I'm no expert. Morphman does work though. Even in 2.1.54

yaoberh avatar Jul 16 '22 12:07 yaoberh

Good to hear :-)

I don’t need to use MorphMan at the moment¹, but when I do I will test that on my system as well. It’s not the first time a certain version of Anki breaks things with add-ons, but later versions work just fine.

¹ I avoid learning any new cards until my PhD dissertation is submitted… 📚

rwmpelstilzchen avatar Jul 16 '22 23:07 rwmpelstilzchen

the stats counter in the toolbar is not working. The link in the toolbar seems to be added with a hook ("top_toolbar_did_redraw") and the morphman preferences are loaded also via a hook ("addHook('profileLoaded', init_preferences)"). The problem seems to be that the toolbar hook is called before the preferences hook and the stats cannot be loaded. I would like to contribute in this project if possible. Still trying to understand the code.

rameauv avatar Jul 17 '22 07:07 rameauv

Thanks, @rameauv! ^_^

rwmpelstilzchen avatar Jul 17 '22 11:07 rwmpelstilzchen

That's strange about the toolbar. Working for me in 2.1.54 and it never stopped working...

yaoberh avatar Jul 17 '22 14:07 yaoberh

I'm on macos v12.3.1, with anki 2.1.54 qt5

rameauv avatar Jul 18 '22 01:07 rameauv

Could be a Mac/qt5 related problem

yaoberh avatar Jul 21 '22 12:07 yaoberh

There are at least 2 known issues with 2.1.50 and newer. If it works fine on your system, then feel free to download the zip file and install it manually. This is the same file hosted by AnkiWeb. To make things easier for less tech savvy users, I won't update the version on AnkiWeb until it's fully supported.

Also @rameauv we'd love to have your help! I don't have a ton of time to make contributions, right now I just work to keep AnkiWeb updated with whatever contributions the community (mainly ianki, recently) makes.

landonepps avatar Aug 01 '22 04:08 landonepps

I finished writing my dissertation, so I can relax a bit my Anki ‘abstinence’ and check MorphMan. So far, I encountered no problems with this version on Anki version ⁨2.1.54 (b6a7760c)⁩ running on Linux.

rwmpelstilzchen avatar Aug 21 '22 12:08 rwmpelstilzchen

Well, there are problems with the v3 scheduler (#276), but this seems unrelated to the version of Anki. I tested this on both 2.1.49 and 2.1.54, with the same results: MorphMan’s automatic skipping works on v2 but not on v3.

rwmpelstilzchen avatar Aug 24 '22 12:08 rwmpelstilzchen

The fact that morphman dosen't automatically skip words is not a problem. You can just press ctrl+M to manually skip

Vilhelm-Ian avatar Nov 04 '22 06:11 Vilhelm-Ian

The fact that morphman dosen't automatically skip words is not a problem. You can just press ctrl+M to manually skip

This should be done automatically. Doing so manually is unnecessary and laboursome.

rwmpelstilzchen avatar Dec 01 '22 12:12 rwmpelstilzchen

@rwmpelstilzchen I made a pull request to fix the bug I talked about. This bug is also referenced here https://github.com/kaegi/MorphMan/issues/262

rameauv avatar Dec 12 '22 06:12 rameauv

AnkiWeb is officially updated to the new v5.0 alpha. https://github.com/kaegi/MorphMan/releases/tag/v5.0-qt6-alpha.1 Thanks @rameauv for the toolbar fix.

If you come across any new bugs with the pre-release version please create an issue.

landonepps avatar Jan 10 '23 20:01 landonepps