MorphMan
MorphMan copied to clipboard
[BUG] Ignore everything contained within () brackets feature not working
A card with(観客たち)おおーっ
comes up with 観客 as an unknown despite Ignore everything contained within () brackets.
Being checked. I'm guessing because ( are unicode not ascii (?
UPDATE: I confirmed it's happening for a card with ascii as well:
(観客たち)スメルズ ライク バッド スピリッツ!!
Just did some testing on this. My regular brackets were ignored correctly, but the japanese ones weren't. But according to the code it should only work for japanese brackets.
I just turned the brackets feature off, did a recalc, turned it on again, did a recalc. And now my english brackets no longer work (as expected by the code, but they were definitely working before)
I'm going to see if I can work out the bug and fix it for both Japanese & English brackets
I don't think the current PR is good, as it only tries to solve the English brackets
I've created a new PR for addressing both English/Japanese brackets #175
I think there are some other bugs on master to do with preference saving which are getting in the way a bit (I can't seem to turn off the bracket options currently)
I'm pretty sure the brackets problems I had can be solved with these fixes:
- Non-Japanese brackets not supported - fix in #175
- Preferences not saving properly - fix in #127
- Recalc only affects modified notes, but not when preferences updated (e.g. brackets setting) - issue #177 (currently no fix)
I think this need may be addressed by #194. Please try.
Do we think there should be different settings for slim/full brackets? I'm not fully against it, but I would assume most people would see round brackets as one option.