kadence-blocks icon indicating copy to clipboard operation
kadence-blocks copied to clipboard

Published 20 hours ago • verified publisher icon kadencewp

kadence-blocks-author-svg-support

Open wixaw opened this issue 4 years ago • 4 comments

Hello

I find this http://download.kadencethemes.com/kadence-blocks-author-svg-support.zip here : https://wordpress.org/support/topic/svg-parsing-error-for-lower-user-roles/

It was improbable and unexpected to find this kind of solution. Can't merge this to the original plugin?

Thank you in advance

wixaw avatar Oct 28 '20 13:10 wixaw

At this time there are no plans to import that. It's not a great solution, it's simply a hack that can work most of the time. For some SVGS it still will not work because of how kses breaks svgs with x1 and y1 attributes.

There are tickets open in core that would provide a better fix so we are hoping core deals with the problem as it's not specific to our plugin.

Ben

kadencewp avatar Nov 04 '20 05:11 kadencewp

Okay, even temporarily? Sometimes core fixes take months to be merged I almost deactivated your plugin, it would have been a shame to lose so much functionality Will

wixaw avatar Nov 04 '20 08:11 wixaw

Hey,

I get it and I don't like that core is dragging their feet on this problem, I, unfortunately, can't control that.

I don't want to introduce that hack into a production plugin. It's not something I even use in places where I have author permissions or multisite. It's a hack and I can list ways it won't work so I know adding it would add support because you can still break things. Again this is because of core code.

The approach of that hack is all wrong it was an option for some people but not a serious one. I suggest approaching the issue differently. If on a multisite give unfiltered HTML permissions to those that are using the block editor. If you have authors on a single site do that same. The "security" threat of doing this is in my opinion, not a real issue. And while we are on that if it is a concern for you that users with permission to work in Gutenberg need to be prevented from adding dangerous HTML to a page then I can't suggest you use the above plugin as it's going to open a possible way for someone to do that through SVG markup.

All the best!

kadencewp avatar Nov 18 '20 23:11 kadencewp

Okay and thank you for this complete answer My case is a single site with multi author, but I have more than 60 sites like this But okay no worries, we're waiting Have a good day William

wixaw avatar Nov 19 '20 07:11 wixaw