Tomas Kral

Results 315 comments of Tomas Kral

we could also add `app.kubernetes.io/deploy-manager: kedge` as a label

hmm, that is strange it works on OpenShift but not on Kubernetes (minishift/minikube). We should report it so it can be fixed. Those CentOS images are in really bad shape.

Agreed, we should have something like this. A few notes regarding this: Chart shouldn't be tied to any given Kedge app. That means it can't be done in the way...

As a rule, we don't want to redefine the behavior of keys from Kubernetes artifacts. We have Deployment (or other controllers) at the root level of Kedge YAML, that means...

> @kadel how about adding root level namespace to every generated Kubernetes object if it is not passed in explicitly. That is what the user will expect when he/she will...

> @containscafeine auto-population from where ? I am not sure what you mean here? @surajssd, what @containscafeine means is that we should do the same thing with with `namespace` as...

I'm definitely against random naming or asking a user. Everything should be defined in the file. Image name might work. But to be honest I don't think this is such...

One place where you are referring to containers are commands like `kubectl exec` or `kubectl logs`

From my short experimenting with fabric8-maven-plugin this is not something that it is doing. What if someone explicitly doesn't want health checks?

@surajssd > So we read what port the service is exposed on and we compare that port against our internal mapping, if there exist a mapping and user has not...