kactus icon indicating copy to clipboard operation
kactus copied to clipboard

Commit panel doesn't show

Open yceballost opened this issue 4 years ago • 16 comments

Describe the bug

After a change, commit panel is hide.

Version & OS

Version 0.3.27 OS Catalina 10.15.3

Steps to reproduce the behavior

  1. Make a change in a sketch file
  2. Go to Kactus
  3. Try to commit, but the commit panel doesn't appear.

Screenshots

kactusIssue

yceballost avatar Apr 02 '20 17:04 yceballost

same here. noticed on some rep, it shows, for some, it doesn't

anthonymiao avatar Apr 02 '20 19:04 anthonymiao

Hum weird, it shows fine whatever I try to do. Can you think of anything specific that would make it happen? Otherwise, can you try to open the dev tools (cmd + alt + i), click on the small icon the top left and click on the list of changes? It should show something like Screenshot 2020-04-02 at 22 50 02

mathieudutour avatar Apr 02 '20 21:04 mathieudutour

Yes, I can see it

Screenshot 2020-04-02 at 23 29 57

yceballost avatar Apr 02 '20 21:04 yceballost

and when you hover on it, it doesn't highlight anything? What is its size? (Just trying to figure out where that div has gone)

mathieudutour avatar Apr 02 '20 21:04 mathieudutour

wow, the height is increasing crazy xD (and still increasing like a counter)

Screenshot 2020-04-02 at 23 37 02

yceballost avatar Apr 02 '20 21:04 yceballost

😬 I'll try to repro

mathieudutour avatar Apr 02 '20 21:04 mathieudutour

I'm publishing a new version (should be deployed in ~20min). Let me know if it fixes it

mathieudutour avatar Apr 02 '20 21:04 mathieudutour

I'm publishing a new version (should be deployed in ~20min). Let me know if it fixes it

Thanks @mathieudutour — I just updated my client, but I'm seeing the same issues other describe

josephs avatar Apr 03 '20 06:04 josephs

Me too, I can't see the commit panel at the begining. But now the height is stucked in 1041px. (depends on the size of the windows when you open Kactus)

If I open Kactus and resize windows I can see the panel, but when the size of the windows arrive at the end of the commit panel, this area move down

yceballost avatar Apr 03 '20 07:04 yceballost

But now the height is stucked in 1041px. (depends on the size of the windows when you open Kactus)

That's the stopgap I put yesterday. So now I know what's the issue is, but I don't know why it's happening haha. Still looking into it

mathieudutour avatar Apr 03 '20 07:04 mathieudutour

.list-focus-container {
    max-height: 1px;
}

Solve the problem apparently (I don't believe this is the best solution, but works)

yceballost avatar Apr 03 '20 07:04 yceballost

Well I really can't figure out how to reproduce so I'm just going to trust you that it fixes it and publish a new version. Doesn't seem to hurt in my case so ¯_(ツ)_/¯

mathieudutour avatar Apr 03 '20 07:04 mathieudutour

publishing 0.3.29, let me know if it's fine

mathieudutour avatar Apr 03 '20 07:04 mathieudutour

I discovered how to reproduce the issue

  1. Create a new repo
  2. Add with button "+" a new sketch file
  3. Add another sketch file
  4. Add another one

Now, you should see the commit panel is moving down

yceballost avatar Apr 03 '20 08:04 yceballost

same here version 0.3.29 in version 0.3.25 everything was fine. maybe that helps to find the reason.

altran-fabian avatar Apr 16 '20 17:04 altran-fabian

I have just found the same issue, only for specific repos. On the current version 0.3.29.

Have tried multiple restarts and a machine restart with no luck

iantodd87 avatar Jun 02 '20 15:06 iantodd87